util/managedfile: create symlink when staging files for local providers #1683
Conversation
When a local TFTPProviderDriver/HTTPProviderDriver is used, the file sync can be skipped but the symlink creation in the server internal directory shouldn't. Signed-off-by: Robin van der Gracht <[email protected]> [bst: adjust commit message to fit common style]
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #1683 +/- ##
========================================
- Coverage 55.7% 55.7% -0.1%
========================================
Files 171 172 +1
Lines 13408 13422 +14
========================================
+ Hits 7477 7479 +2
- Misses 5931 5943 +12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Bastian-Krause
added
picked to stable
| conn.run_check(f"ln -sfn {self.rpath}{os.path.basename(self.local_path)} {symlink}") | ||
|
|
||
| else: | ||
| conn = sshmanager.open("localhost") |
There was a problem hiding this comment.
This looks broken, why do we need to open an SSH connection when operating on a local machine? This breaks the sandboxed tests on nixpkgs since we now open SSH connections for tests that never did this before.
There was a problem hiding this comment.
Hm okay, I thought it would be a good idea to not duplicate the symlinking logic locally in Python, but you're right, it would actually be better.
Description
When a local TFTPProviderDriver/HTTPProviderDriver is used, the file sync can be skipped but the symlink creation in the server internal directory shouldn't.
Commit by @rvdgracht taken from #1662, leaving the maybe controversial part of creating the directory there for further discussion.
Checklist